1. -- init pid algorithm
   
   
2. if not p then
   
   
3.   p = PID:init({
   
   
4.     current = '1/1/1',
   
   
5.     setpoint = '18',
   
   
6.     output = '1/1/3'
   
   
7.   })
   
   
8. end
   
   
9.  
   
   
10. -- run algorithm
    
    
11. p:run()
    

(25.12.2019, 11:00)Erwin van der Zwart Wrote: Hi,

Can you check the script if it uses grp.update instead of grp.write?

grp.update sends to IP but not TP so you can see it on ETS monitor IP side but it’s not send to the TP, i guess that’s the issue you are facing.

BR,

Erwin

(25.12.2019, 11:09)admin Wrote: From group monitor screenshot it looks like you have KNX TP/IP loop. Do you have any other IP interfaces connected to the same TP line?

(25.12.2019, 16:13)Erwin van der Zwart Wrote: Hi,

You don’t need to use the Siemens interface as the controller does the same functions, you can remove it. if you keep using it then disable KNX IP features in the KNX settings.

BR,

Erwin

(12.12.2019, 21:22)josdegroot Wrote: Hopefully someone can help me with the following "problem".

I would like to use the PID script to control the temperature in one of the bedrooms.

The temperature have to be set to 18 degrees... if under setpoint set groupadress ON, if setpoint reached set groupadress OFF.

I saw this example script, but the setpoint must not be an groupadress but a fixed value..

1. -- init pid algorithm
   
   
2. if not p then
   
   
3.   p = PID:init({
   
   
4.     current = '1/1/1',
   
   
5.     setpoint = '18',
   
   
6.     output = '1/1/3'
   
   
7.   })
   
   
8. end
   
   
9.  
   
   
10. -- run algorithm
    
    
11. p:run()
    

This script gives the following error:

Resident script:3: attempt to index global 'PID' (a nil value)
stack traceback:

So I think I made a mistake in the setpoint notation... can somebody help me?

Best,

Jos

(10.06.2022, 12:54)admin Wrote: Add this to Common functions:

Code:

PID = {
  -- default params
  defaults = {
    -- invert algorithm, used for cooling
    inverted = false,
    -- minimum output value
    min = 0,
    -- maximum output value
    max = 100,
    -- proportional gain
    kp = 1,
    -- integral gain
    ki = 1,
    -- derivative gain
    kd = 1,
  }
}

-- PID init, returns new PID object
function PID:init(params)
  local n = setmetatable({}, { __index = PID })
  local k, v

  -- set user parameters
  n.params = params

  -- copy parameters that are set by user
  for k, v in pairs(PID.defaults) do
    if n.params[ k ] == nil then
      n.params[ k ] = v
    end
  end

  -- reverse gains in inverted mode
  if n.params.inverted then
    n.params.kp = -n.params.kp
    n.params.ki = -n.params.ki
    n.params.kd = -n.params.kd
  end

  return n
end

-- resets algorithm on init or a switch back from manual mode
function PID:reset()
  -- previous value
  self.previous = grp.getvalue(self.params.current)
  -- reset iterm
  self.iterm = 0
  -- last running time
  self.lasttime = os.time()

  -- clamp iterm
  self:clampiterm()
end

-- clamps iterm value
function PID:clampiterm()
  self.iterm = math.max(self.iterm, self.params.min)
  self.iterm = math.min(self.iterm, self.params.max)
end

-- clamp and set new output value
function PID:setoutput()
  local t, object, value

  self.output = math.max(self.output, self.params.min)
  self.output = math.min(self.output, self.params.max)

  value = math.floor(self.output)
  local t = type(self.params.output)

  -- write to output if object is set
  if t == 'string' or t == 'table' then
    if t == 'string' then
      self.params.output = { self.params.output }
    end

    for _, output in ipairs(self.params.output) do
      grp.write(output, value, dt.scale)
    end
  end
end

-- algorithm step, returns nil when disabled or no action is required, output value otherwise
function PID:run()
  local result

  -- get manual mode status
  local manual = self.params.manual and grp.getvalue(self.params.manual) or false

  -- in manual mode, do nothing
  if manual then
    self.running = false
  -- not in manual, check if reset is required after switching on
  elseif not self.running then
    self:reset()
    self.running = true
  end

  -- compute new value if not in manual mode
  if self.running then
    -- get time between previous and current call
    local now = os.time()
    self.deltatime = now - self.lasttime
    self.lasttime = now

    -- run if previous call was at least 1 second ago
    if self.deltatime > 0 then
      result = self:compute()
    end
  end

  return result
end

-- computes new output value
function PID:compute()
  local current, setpoint, deltasc, deltain, output

  -- get input values
  current = grp.getvalue(self.params.current)
  setpoint = grp.getvalue(self.params.setpoint)

  -- delta between setpoint and current
  deltasc = setpoint - current

  -- calculate new iterm
  self.iterm = self.iterm + self.params.ki * self.deltatime * deltasc
  self:clampiterm()

  -- delta between current and previous value
  deltain = current - self.previous

  -- calculate output value
  self.output = self.params.kp * deltasc + self.iterm
  self.output = self.output - self.params.kd / self.deltatime * deltain

  -- write to output
  self:setoutput()

  -- save previous value
  self.previous = current

  return self.output
end

(10.06.2022, 13:58)admin Wrote: Check that setpoint object address is valid in the pid script.

(10.06.2022, 14:12)admin Wrote: Restart the script via disable/enable. Also inverted should be false not 0. Because 0 evaluates as "true".