Could you define what means "not working"? What is current state of your system?
But probably I've found the source of problem Please log in "Object logs" valve status because for 99% you are updating your valve every minute(not only on change) so the timestamp is updated and is still too fresh and is recognized as not fully open.
Looks in logs:
[valvesInSummer]
* table:
[1]
* table:
[value]
* bool: true
[firstTimestamp]
* number: 1540829552
[name]
* string: T7 FB Heating floor attic valve
[opened]
* bool: true
[valvesInSummer]
* table:
[1]
* table:
[value]
* bool: true
[firstTimestamp]
* number: 1540829612
[name]
* string: T7 FB Heating floor attic valve
[opened]
* bool: true
[valvesInSummer]
* table:
[1]
* table:
[value]
* bool: true
[firstTimestamp]
* number: 1540829672
[name]
* string: T7 FB Heating floor attic valve
[opened]
* bool: true
Everytime script runs there is different firstTimestamp which is equal to updatetime of valve with alias 'T7 FB Heating floor attic valve'. So the status of this valve is updated every minute. But this is not by this script because this script only controls the pump based on valve statuses.
I think you are upodating state of valve every minute. Please log
But probably I've found the source of problem Please log in "Object logs" valve status because for 99% you are updating your valve every minute(not only on change) so the timestamp is updated and is still too fresh and is recognized as not fully open.
Looks in logs:
[valvesInSummer]
* table:
[1]
* table:
[value]
* bool: true
[firstTimestamp]
* number: 1540829552
[name]
* string: T7 FB Heating floor attic valve
[opened]
* bool: true
[valvesInSummer]
* table:
[1]
* table:
[value]
* bool: true
[firstTimestamp]
* number: 1540829612
[name]
* string: T7 FB Heating floor attic valve
[opened]
* bool: true
[valvesInSummer]
* table:
[1]
* table:
[value]
* bool: true
[firstTimestamp]
* number: 1540829672
[name]
* string: T7 FB Heating floor attic valve
[opened]
* bool: true
Everytime script runs there is different firstTimestamp which is equal to updatetime of valve with alias 'T7 FB Heating floor attic valve'. So the status of this valve is updated every minute. But this is not by this script because this script only controls the pump based on valve statuses.
I think you are upodating state of valve every minute. Please log
Done is better than perfect