This forum uses cookies
This forum makes use of cookies to store your login information if you are registered, and your last visit if you are not. Cookies are small text documents stored on your computer; the cookies set by this forum can only be used on this website and pose no security risk. Cookies on this forum also track the specific topics you have read and when you last read them. Please confirm that you accept these cookies being set.

Processing KNX Addresses
#21
Looks better but since I don't know what exactly this script should be doing I can't tell if it's fully correct or not.

Couple of things to consider:
1. Event value is not used / checked at all.

2. readAndSetTemperature is called in a loop so grp.getvalue inside is called 10 times where as it could be one. The code can be optimized like this, so readAndSetTemperature is not needed:
Code:
local outValue

if zeroValue == false or controlValue == true then
  outValue = 0
else
  outValue = grp.getvalue(group .. '/0/15')
end

for j = 17, 117, 10 do
  local addr = group .. '/4/' .. j
  grp.checkwrite(addr, outValue)
end
Reply


Forum Jump: